mihaibudiu commented on code in PR #4388:
URL: https://github.com/apache/calcite/pull/4388#discussion_r2098598102
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -8782,6 +8782,12 @@ void testGroupExpressionEquivalenceParams() {
sql("select stream * from orders left join products_temporal\n"
+ "for system_time as of CURRENT_TIMESTAMP\n"
+ "on orders.productid = products_temporal.productid").ok();
+
+ // verify left join of CTEs
Review Comment:
I think that this query is illegal according to the "standard" definition of
SYSTEM_TIME.
You can make the method overridable, but is there even a definition of what
it means to apply SYSTEM_TIME to the result of a query?
If you want it in here it should be applied to products_temporal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
