xiedeyantu commented on code in PR #4405:
URL: https://github.com/apache/calcite/pull/4405#discussion_r2157883142
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8772,6 +8772,64 @@ private void checkLiteral2(String expression, String
expected) {
.withOracle(11).ok(expectedVersionLow1);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5583";>[CALCITE-5583]
+ * Rel2Sql will get an error when select * and join is present</a>. */
+ @Test void testSelectStarWithJoinOn() {
+ final String sql = "SELECT * FROM \"DEPT\" t1 "
+ + "LEFT JOIN (SELECT * FROM (SELECT DEPTNO AS c0 FROM \"DEPT\") t "
+ + "INNER JOIN (SELECT DEPTNO AS c0 FROM \"DEPT\") t0 ON t.c0 = t0.c0)
t2 "
+ + "ON t1.DEPTNO = t2.c0";
+ final String expectedPostgres = "SELECT *\n"
+ + "FROM \"SCOTT\".\"DEPT\"\n"
+ + "LEFT JOIN (SELECT \"t\".\"C0\", \"t0\".\"C0\" AS \"C00\"\n"
+ + "FROM (SELECT \"DEPTNO\" AS \"C0\"\n"
+ + "FROM \"SCOTT\".\"DEPT\") AS \"t\"\n"
+ + "INNER JOIN (SELECT \"DEPTNO\" AS \"C0\"\n"
+ + "FROM \"SCOTT\".\"DEPT\") AS \"t0\""
+ + " ON \"t\".\"C0\" = \"t0\".\"C0\") AS \"t1\""
+ + " ON \"DEPT\".\"DEPTNO\" = \"t1\".\"C0\"";
+ sql(sql)
+ .schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
+ .withPostgresql().ok(expectedPostgres);
+ }
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5583";>[CALCITE-5583]
+ * Rel2Sql will get an error when select * and join is present</a>. */
+ @Test void testSelectStarWithJoinUsing() {
+ final String sql = "select * from EMP JOIN DEPT USING (DEPTNO)";
+ final String expectedPostgres = ""
+ + "SELECT COALESCE(\"EMP\".\"DEPTNO\", \"DEPT\".\"DEPTNO\") AS
\"DEPTNO\", "
+ + "\"EMP\".\"EMPNO\", \"EMP\".\"ENAME\", \"EMP\".\"JOB\",
\"EMP\".\"MGR\", "
+ + "\"EMP\".\"HIREDATE\", \"EMP\".\"SAL\", \"EMP\".\"COMM\",
\"DEPT\".\"DNAME\", "
+ + "\"DEPT\".\"LOC\"\n"
+ + "FROM \"SCOTT\".\"EMP\"\n"
+ + "INNER JOIN \"SCOTT\".\"DEPT\" "
+ + "ON \"EMP\".\"DEPTNO\" = \"DEPT\".\"DEPTNO\"";
+ sql(sql)
+ .schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
+ .withPostgresql().ok(expectedPostgres);
+ }
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5583";>[CALCITE-5583]
+ * Rel2Sql will get an error when select * and join is present</a>. */
+ @Test void testSelectStarWithJoinNatural() {
Review Comment:
These tests are carried by the original PR, which I understand is Julian's
previous comment. So I kept these two.
[link](https://github.com/apache/calcite/pull/3375#discussion_r1300752310)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
