xiedeyantu commented on code in PR #4405:
URL: https://github.com/apache/calcite/pull/4405#discussion_r2157944312


##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -797,6 +797,11 @@ public boolean supportBooleanCaseWhen() {
     return true;
   }
 
+  /** Returns whether this dialect supports generate 'SELECT *' when duplicate 
field names. */
+  public boolean supportGenerateSelectStar() {

Review Comment:
   Great suggestion, this makes the code logic clearer. I will revise according 
to this suggestion later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to