suibianwanwank commented on PR #4437:
URL: https://github.com/apache/calcite/pull/4437#issuecomment-3000647874
> @suibianwanwank thanks! The only thing I'm a little bit concerned about is
that `LogicalProject` now exposes `variablesSet` in certain cases. But as far
as I see this is valid approach to force `RelBuilder` not to merge projections:
>
> ```
> // org.apache.calcite.tools.RelBuilder#project_:
> <...>
>
> // Do not merge projection when top projection has correlation
variables
> bloat:
> if (frame.rel instanceof Project
> && config.bloat() >= 0
> && variables.isEmpty()) {
> ```
I don't quite understand what 'exposes' means here. From my understanding,
`variablesSet'`is indispensable, in nested subQueries, it clearly defines the
source of variables. But in many rules and programs, 'variablesSet' gets
discarded. In my other uncommitted branches, I've made some related fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
