korlov42 commented on PR #4437: URL: https://github.com/apache/calcite/pull/4437#issuecomment-3000700402
> From my understanding, variablesSet'is indispensable, in nested subQueries, it clearly defines the source of variables. I absolutely agree with you. I only wanted to highlight that this particular change (even though I believe it's perfectly valid) is not directly relates to the problem I'm addressing in this patch, and different parts of the system may or may not consider `variablesSet` returned by Project rel. In other words, this particular change may cause a different execution path in some environments, hence may cause a "regression" (again, there are a lot of IF's, and I don't think this change is or will be the root cause, but rather trigger which will highlight problem somewhere else). Anyway, I just wanted to share my thoughts on the matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
