mihaibudiu commented on code in PR #4547:
URL: https://github.com/apache/calcite/pull/4547#discussion_r2365856596
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -3720,7 +3720,7 @@ public RelBuilder sort(Iterable<? extends RexNode> nodes)
{
}
/** Creates a {@link Sort} by expressions, with limit and offset. */
- public RelBuilder sortLimit(long offset, long fetch, RexNode... nodes) {
+ public RelBuilder sortLimit(Number offset, Number fetch, RexNode... nodes) {
Review Comment:
I think you can leave this API unchanged.
Moreover, it's a public function.
Number includes Double, so it's a bit too much.
It's fine on the getter side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
