xiedeyantu commented on code in PR #4547:
URL: https://github.com/apache/calcite/pull/4547#discussion_r2365870194
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -3720,7 +3720,7 @@ public RelBuilder sort(Iterable<? extends RexNode> nodes)
{
}
/** Creates a {@link Sort} by expressions, with limit and offset. */
- public RelBuilder sortLimit(long offset, long fetch, RexNode... nodes) {
+ public RelBuilder sortLimit(Number offset, Number fetch, RexNode... nodes) {
Review Comment:
The most primitive method originally had an int parameter, which was changed
to long in the previous modification. However, as you mentioned, it is indeed
public. If I keep both versions simultaneously, should I change the parameter
of the original version back to int?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
