xiedeyantu commented on code in PR #4548:
URL: https://github.com/apache/calcite/pull/4548#discussion_r2366224893
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -518,4 +518,13 @@ public enum SqlConformanceEnum implements SqlConformance {
return false;
}
}
+
+ @Override public boolean isNonStrictGroupBy() {
+ switch (this) {
+ case BABEL:
+ return true;
Review Comment:
I checked and found that MySQL has always supported the
[ONLY_FULL_GROUP_BY](https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_only_full_group_by)
mode, but it wasn't until version 5.7.5 that it was enabled by default. In
Calcite, there is only one MYSQL_5 Conformance, and I'm not sure if adding
MYSQL_5 here is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
