xiedeyantu commented on code in PR #4548: URL: https://github.com/apache/calcite/pull/4548#discussion_r2370543860
########## core/src/test/resources/sql/agg.iq: ########## @@ -4126,4 +4126,40 @@ GROUP BY DEPTNO, JOB; !ok +# [CALCITE-7189] Support MySQL-style non-standard GROUP BY +!use scott-babel Review Comment: Oh, I see your point now. I found its implementation, and it looks like it's implemented using "MinMax" (https://github.com/apache/calcite/pull/735/files#diff-2095e662d66d6c1b2851915fa0d73934c3a847550545396835e02d88a9f5e2daR447). So within Calcite, it might be a deterministic function. In the PR that implemented "ANY_VALUE", they also used ".iq" tests to verify the results. So this test is probably safe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
