cjj2010 commented on code in PR #4818:
URL: https://github.com/apache/calcite/pull/4818#discussion_r2902810651
##########
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java:
##########
@@ -129,6 +129,9 @@ public HiveSqlDialect(Context context) {
case TRIM:
RelToSqlConverterUtil.unparseHiveTrim(writer, call, leftPrec, rightPrec);
break;
+ case REGEXP:
Review Comment:
> Judging from your Jira information, you want to add a new function, right?
If you add this function, the dialect won't need to be modified.
Yes, REGEXP is an infix operator in Hive, but there is already a REGEXP
function in Cacltie. If another REGEXP operator is added, the original SQL
parsing will report an error: "Incorrect syntax near the keyword 'REGEXP'".
Therefore, my idea is to convert the REGEXP function into a REGEXP operator
based on the Hive dialect, I'm not sure if this is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
