xuzifu666 commented on code in PR #4818:
URL: https://github.com/apache/calcite/pull/4818#discussion_r2903471767
##########
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java:
##########
@@ -129,6 +129,9 @@ public HiveSqlDialect(Context context) {
case TRIM:
RelToSqlConverterUtil.unparseHiveTrim(writer, call, leftPrec, rightPrec);
break;
+ case REGEXP:
Review Comment:
Another point is that, as I understand it from Jira's perspective, there's
no need to introduce a new SqlKind.
##########
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##########
@@ -1357,7 +1357,10 @@ public enum SqlKind {
* commands for them. Use OTHER_DDL in the short term, but we are happy to
add
* new enum values for your object types. Just ask!
*/
- OTHER_DDL;
+ OTHER_DDL,
+
+ /** The {@code REGEXP} function. */
+ REGEXP;
Review Comment:
Why make this change? If it were a dialect conversion, it could be
determined using ```SqlOperator```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
