Dwrite commented on code in PR #4828:
URL: https://github.com/apache/calcite/pull/4828#discussion_r2924974296
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -11887,6 +11887,39 @@ public Sql schema(CalciteAssert.SchemaSpec schemaSpec)
{
sql(sql).schema(CalciteAssert.SchemaSpec.JDBC_SCOTT).ok(expected);
}
+ /** Test case for
Review Comment:
The current test case
testPostgresqlRoundTripCorrelatedProjectWithSemiJoinRules covers the scenario
where optimization rules are applied. To ensure the fix is robust for the core
RelToSql mapping logic, would it be better to add a plain test case without
these rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
