bvolpato commented on PR #4828: URL: https://github.com/apache/calcite/pull/4828#issuecomment-4105331678
@xiedeyantu I addressed the test-structure part of your note: - removed the `try-catch` from `testPostgresqlRoundTripCorrelatedProjectWithSemiJoinRules` - updated the PR description so it matches the retained reproducer and current fix On the Jira alias suggestion: I considered it, but I kept this PR scoped to the failure mode reproduced here. The retained regression still fails on `main` and passes with this patch, while changing alias generation in `visit(Correlate)` would be a broader behavior change than the NPE fix in this PR. If you want, I can also split out the alias-cleanup direction as a separate follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
