xiedeyantu commented on PR #4803: URL: https://github.com/apache/calcite/pull/4803#issuecomment-4115302189
I don't object to merging this PR — it's a very good optimization. I'm not particularly worried about correctness either; it's just that more comprehensive testing would be more convincing. Maybe I'm overthinking, but I'm concerned that this flag might never be removed. Perhaps we could add a little more context, marking it as an experimental feature? I have no other suggestions beyond that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
