xiedeyantu commented on PR #4803: URL: https://github.com/apache/calcite/pull/4803#issuecomment-4115381720
Perhaps I didn't make myself clear. This cache optimization hasn't gone through extensive testing, so strictly speaking, its correctness could be questionable. Just like when we previously introduced new decorrelation and the new DpHyp — even though there was a lot of testing to prove they were correct, we still marked them as experimental, as they hadn't undergone extensive production validation. So, I think the entire feature could be marked as experimental. The above is just to clarify what I didn't explain clearly in my previous reply. As for this PR, I don't have many more suggestions. It can be kept as is, and let's prepare to merge it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
