Copilot commented on code in PR #4893:
URL: https://github.com/apache/calcite/pull/4893#discussion_r3106316727
##########
file/src/main/java/org/apache/calcite/adapter/file/CsvStreamReader.java:
##########
@@ -54,8 +54,12 @@ class CsvStreamReader extends CSVReader implements Closeable
{
public static final long DEFAULT_MONITOR_DELAY = 2000;
CsvStreamReader(Source source) {
+ this(source, CSVParser.DEFAULT_SEPARATOR);
+ }
+
+ CsvStreamReader(Source source, char separator) {
this(source,
- CSVParser.DEFAULT_SEPARATOR,
+ separator,
CSVParser.DEFAULT_QUOTE_CHARACTER,
CSVParser.DEFAULT_ESCAPE_CHARACTER,
Review Comment:
Now that CsvStreamReader exposes a constructor that accepts a custom
separator, the class Javadoc for readNext() (later in this file) still
describes the result as “comma-separated”. That wording is misleading for
non-comma separators; update it to be delimiter/separator-agnostic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
