xiedeyantu commented on code in PR #4893: URL: https://github.com/apache/calcite/pull/4893#discussion_r3109556552
########## file/src/test/resources/sales-csv/PIPE_DELIMITED.csv: ########## @@ -0,0 +1,4 @@ +DEPTNO:int|NAME:string +10|"Sales" +20|"Marketing" +30|"Accounts" Review Comment: Could you add a test record containing an escape character? I'd like to verify whether the custom delimiter and escape character function correctly in combination. Additionally, I had another thought: regarding support for custom escape characters—I'm not sure if Calcite supports this, though naturally, this doesn't necessarily need to be implemented in the current PR. Overall, this PR looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
