rubenada commented on PR #5204: URL: https://github.com/apache/calcite/pull/5204#issuecomment-5372943735
> Not easy to tell by eye whether all the places where the conversion happens have been instrumented. > > I wonder whether the exception message size is a concern. Is the problem only when the original literal is small but the internal representation is large? The problem is mostly when `toPlainString` method is used, whose OOM risk can be quite high. I have searched manually the callers of this method, and I think the PR covers all places susceptible to have a potential OOM risky input value from the user. There was another occurrence in `SqlImplementor`, I've just included the check in there just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
