rubenada commented on PR #5204: URL: https://github.com/apache/calcite/pull/5204#issuecomment-5385243886
@skrcode you're right, initially I planned to apply this patch at SqlParser level only (which seems the more likely scenario for a risky user-defined input leading to this potential OOM situation), but finally I decided to include the check also in other (potentially risky) places calling BigDecimal#toPlainString (but did not add tests for them). You can open a separate, follow-up PR to add the extra tests to improve our test coverage. We'd appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
