rubenada commented on code in PR #5184:
URL: https://github.com/apache/calcite/pull/5184#discussion_r3835916443
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1631,12 +1654,31 @@ enum SafeRexVisitor implements RexVisitor<Boolean> {
|| RexUtil.isLosslessCast(call)
|| safeOps.contains(sqlKind)
|| safeOperators.contains(sqlOperator)) {
- return RexVisitorImpl.visitArrayAnd(this, call.operands);
+ return !deep || RexVisitorImpl.visitArrayAnd(this, call.operands);
}
return false;
}
+ /**
+ * Shallow variant of the visitor: reports whether the OUTER node's
+ * operator can be evaluated on non-null operands without throwing at
+ * runtime. Unlike {@link #visitCall(RexCall)}, it does not recurse into
+ * the operands. Callers that only need to know whether the outer
+ * operator itself is safe (e.g. RexSimplify's {@code Strong.ANY}
+ * distribution branches, which preserve subtree evaluation) can use
+ * this in place of the full-tree {@link RexSimplify#isSafeExpression}.
+ *
+ * <p>Non-{@link RexCall} nodes are always shallow-safe (they cannot
+ * throw at their own level).
+ */
+ boolean isShallowSafe(RexNode node) {
Review Comment:
I'd prefer to leave the current name, since the method theoretically could
accept any type of RexNode, and also to avoid confusion with
SqlOperator#isSafeOperator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
