xuzifu666 commented on PR #5384: URL: https://github.com/apache/calcite/pull/5384#issuecomment-6578636534
> I see 6 changes and only 4 tests. Does each change have coverage in the new tests? Thank you for the point, these tests only covered the convertlet change; the rest got flat n-ary input (depth 1) and decomposeDisjunction wasn't reached at all. I added more test case to cover it. Now each of the 6 changes has a dedicated unit test (20k-level binary tree on a 256KB-stack thread), all verified would failed on the main branch. @mihaibudiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
