xuzifu666 commented on code in PR #5384:
URL: https://github.com/apache/calcite/pull/5384#discussion_r4455257075
##########
core/src/test/java/org/apache/calcite/rex/RexUtilTest.java:
##########
@@ -43,4 +54,116 @@ class RexUtilTest {
RexUtil.SubQueryFinder.find(expression, SqlKind.SCALAR_QUERY));
assertNull(RexUtil.SubQueryFinder.find(expression, SqlKind.EXISTS));
}
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5845";>[CALCITE-5845]
+ * StackOverflowError when SQL has a very large predicate with many ANDs</a>.
+ *
+ * <p>Verifies that {@link RexUtil#flattenAnd} does not recurse when given a
Review Comment:
Make sense, the test checks "completes on a small stack", which is the
observable contract. Reworded all six javadocs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
