rubenada commented on code in PR #5370:
URL: https://github.com/apache/calcite/pull/5370#discussion_r4458018478
##########
core/src/main/java/org/apache/calcite/sql/SqlWithItem.java:
##########
@@ -87,6 +96,9 @@ public SqlWithItem(SqlParserPos pos, SqlIdentifier name,
case 4:
cycleClause = (SqlCycleClause) operand;
break;
+ case 5:
Review Comment:
minor: SqlWithItem stores SEARCH as operand 5, after CYCLE (operand 4), even
though SEARCH comes first in the SQL.
Since we have not released any version with CYCLE yet (so no backwards
compatibility issue), would it make sense to switch them to avoid this mismatch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
