vldpyatkov commented on code in PR #5370:
URL: https://github.com/apache/calcite/pull/5370#discussion_r4480833512
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/PhysTypeImpl.java:
##########
@@ -544,6 +530,36 @@ private Expression generateComparator(RelCollation
collation,
});
}
+ private static boolean isComposite(RelDataType type) {
+ return type.isStruct() || type.getComponentType() != null;
+ }
+
+ /** ROW and ARRAY sort keys (including SEARCH columns) are not Comparable.
+ * Use the same element-wise comparator as the single-key sort path. */
+ private static Expression generateComparison(RelDataType type, String method,
Review Comment:
I've separated the fix under
[CALCITE-7919](https://issues.apache.org/jira/browse/CALCITE-7919).
I'd like to merge that fix first, since sorting by the SEARCH key together
with another column can fail without it. Could you please review it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
