rubenada commented on code in PR #5393:
URL: https://github.com/apache/calcite/pull/5393#discussion_r4510791135
##########
core/src/test/java/org/apache/calcite/test/CollectionTypeTest.java:
##########
@@ -65,6 +72,131 @@ class CollectionTypeTest {
"SELECT ARRAY[ROW(MOD(\"ID\", 2), CAST(NULL AS INTEGER))] AS a,\n"
+ "\"ARRAYFIELD\"[1] AS n FROM \"T\"";
+ /** Tests sorting by composite keys in enumerable operators. */
+ @ParameterizedTest
+ @MethodSource("compositeSortCases")
+ void testSortCompositeKeys(String key, String order, boolean limit,
Review Comment:
nit: just to maintain the "convention", please add the classic
```
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-7919";>[CALCITE-7919]
* Enumerable comparators fail with ClassCastException on ROW, ARRAY,
MULTISET and MAP keys</a>. */
```
on the new tests added to this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
