brunoriemenschneider opened a new pull request, #11930: URL: https://github.com/apache/camel/pull/11930
Interface Version functionality as supported by jSMPP is adopted with @UriParam configuration parameter. The default value (interface version 3.4) remains unchanged. The configuration value is parsed as String and converted to hex byte (which is used at protocol level) at a later stage when passed to jSMPP, as Camel does not support hexadecimal byte parsing from config values at this point. (I think the issue is in the Camel support component: the PropertyConfigurerSupport.class does not implement this case) # Description JIRA Ticket CAMEL-20061 The interface version of the SMPP protocol binding can now be specified via configuration parameter. The configuration paramter is simply passed to the underlying library jSMPP as input to the wrapper class BindParameter, which is used for the bind message to establish a connection to an SMSC. The prior default value of SMPP v3.4 is retained as default value. The SMPP protocol defines the bind parameter interface_version as hexadecimal byte. This implementation reads the 0xXX byte value as String, and converts it to byte when passed to jSMPP. This has been done because AFAIK the current implementation in the Camel support component the ProprtyConfigurerSupport.class seems not to support hexadecimal byte configurators. # Target - [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
