davsclaus commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384980130
##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##########
@@ -120,6 +120,8 @@ public class SmppConfiguration implements Cloneable {
private Integer pduProcessorQueueCapacity = 100;
@UriParam(label = "advanced", defaultValue = "false")
private boolean singleDLR;
+ @UriParam(label = "advanced", enums = "0x00,0x33,0x34,0x50", defaultValue
= "0x34")
+ private String interfaceVersion = "0x34";
Review Comment:
Maybe just use a plain string to set the value in better human
understandable as just a string with 3.3, 3.4, 5.0 etc. And then internally
convert that to what jsnmp uses.
##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConsumer.java:
##########
@@ -109,7 +110,8 @@ private SMPPSession createSession() throws IOException {
BindType.BIND_RX, this.configuration.getSystemId(),
this.configuration.getPassword(),
this.configuration.getSystemType(),
TypeOfNumber.UNKNOWN, NumberingPlanIndicator.UNKNOWN,
- configuration.getAddressRange()));
+ configuration.getAddressRange(),
+
InterfaceVersion.valueOf(Byte.decode(configuration.getInterfaceVersion()))));
Review Comment:
See prev comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
