boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457576943
##########
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##########
@@ -460,31 +482,40 @@ public DTLSConnector
createDTLSConnector(InetSocketAddress address, boolean clie
}
PrivateKey privateKey = (PrivateKey) keyStore.getKey(alias,
keyManagers.getKeyPassword().toCharArray());
- builder.setIdentity(privateKey,
keyStore.getCertificateChain(alias));
+ builder.setCertificateIdentityProvider(
+ new SingleCertificateProvider(privateKey,
keyStore.getCertificateChain(alias)));
+
} else if (privateKey != null) {
- builder.setIdentity(privateKey, publicKey);
+ builder.setCertificateIdentityProvider(new
SingleCertificateProvider(privateKey, publicKey));
}
- if (pskStore != null) {
- builder.setPskStore(pskStore);
+ if (advancedPskStore != null) {
+ builder.setAdvancedPskStore(advancedPskStore);
}
// Add all certificates from the truststore
- Certificate[] certs = getTrustedCerts();
+ X509Certificate[] certs = getTrustedCerts();
if (certs.length > 0) {
- builder.setTrustStore(certs);
+
certificateConfigurationHelper.addConfigurationDefaultsForTrusts(certs);
+ builder.setCertificateHelper(certificateConfigurationHelper);
Review Comment:
As I wrote above, I would leave the handling of the
`CertificateConfigurationHelper` to Californium. So remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
