kahboom commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1461906689


##########
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##########
@@ -44,16 +44,16 @@
     "bridgeErrorHandler": { "index": 4, "kind": "parameter", "displayName": 
"Bridge Error Handler", "group": "consumer (advanced)", "label": 
"consumer,advanced", "required": false, "type": "boolean", "javaType": 
"boolean", "deprecated": false, "autowired": false, "secret": false, 
"defaultValue": false, "description": "Allows for bridging the consumer to the 
Camel routing Error Handler, which mean any exceptions (if possible) occurred 
while the Camel consumer is trying to pickup incoming messages, or the likes, 
will now be processed as a message and handled by the routing Error Handler. 
Important: This is only possible if the 3rd party component allows Camel to be 
alerted if an exception was thrown. Some components handle this internally 
only, and therefore bridgeErrorHandler is not possible. In other situations we 
may improve the Camel component to hook into the 3rd party component and make 
this possible for future releases. By default the consumer will use the 
org.apache.camel.spi.
 ExceptionHandler to deal with exceptions, that will be logged at WARN or ERROR 
level and ignored." },
     "exceptionHandler": { "index": 5, "kind": "parameter", "displayName": 
"Exception Handler", "group": "consumer (advanced)", "label": 
"consumer,advanced", "required": false, "type": "object", "javaType": 
"org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.", 
"deprecated": false, "autowired": false, "secret": false, "description": "To 
let the consumer use a custom ExceptionHandler. Notice if the option 
bridgeErrorHandler is enabled then this option is not in use. By default the 
consumer will deal with exceptions, that will be logged at WARN or ERROR level 
and ignored." },
     "exchangePattern": { "index": 6, "kind": "parameter", "displayName": 
"Exchange Pattern", "group": "consumer (advanced)", "label": 
"consumer,advanced", "required": false, "type": "object", "javaType": 
"org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ], 
"deprecated": false, "autowired": false, "secret": false, "description": "Sets 
the exchange pattern when the consumer creates an exchange." },
-    "notify": { "index": 7, "kind": "parameter", "displayName": "Notify", 
"group": "producer", "label": "producer", "required": false, "type": "boolean", 
"javaType": "boolean", "deprecated": false, "autowired": false, "secret": 
false, "defaultValue": false, "description": "Notify observers that the 
resource of this URI has changed, based on RFC 7641. Use this flag on a 
destination endpoint, with an URI that matches an existing source endpoint 
URI." },
+    "notify": { "index": 7, "kind": "parameter", "displayName": "Notify", 
"group": "producer", "label": "producer", "required": false, "type": "boolean", 
"javaType": "boolean", "deprecated": false, "autowired": false, "secret": 
false, "defaultValue": false, "description": "Notify observers that the 
resource of this URI has changed, based on RFC 7641. Use this flag on a 
destination endpoint, with a URI that matches an existing source endpoint URI." 
},
     "lazyStartProducer": { "index": 8, "kind": "parameter", "displayName": 
"Lazy Start Producer", "group": "producer (advanced)", "label": 
"producer,advanced", "required": false, "type": "boolean", "javaType": 
"boolean", "deprecated": false, "autowired": false, "secret": false, 
"defaultValue": false, "description": "Whether the producer should be started 
lazy (on the first message). By starting lazy you can use this to allow 
CamelContext and routes to startup in situations where a producer may otherwise 
fail during starting and cause the route to fail being started. By deferring 
this startup to be lazy then the startup failure can be handled during routing 
messages via Camel's routing error handlers. Beware that when the first message 
is processed then creating and starting the producer may take a little time and 
prolong the total processing time of the processing." },
-    "alias": { "index": 9, "kind": "parameter", "displayName": "Alias", 
"group": "security", "label": "security", "required": false, "type": "string", 
"javaType": "java.lang.String", "enum": [ "NONE", "WANT", "REQUIRE" ], 
"deprecated": false, "autowired": false, "secret": false, "description": "Sets 
the alias used to query the KeyStore for the private key and certificate. This 
parameter is used when we are enabling TLS with certificates on the service 
side, and similarly on the client side when TLS is used with certificates and 
client authentication. If the parameter is not specified then the default 
behavior is to use the first alias in the keystore that contains a key entry. 
This configuration parameter does not apply to configuring TLS via a Raw Public 
Key or a Pre-Shared Key." },
-    "cipherSuites": { "index": 10, "kind": "parameter", "displayName": "Cipher 
Suites", "group": "security", "label": "security", "required": false, "type": 
"string", "javaType": "java.lang.String", "deprecated": false, "autowired": 
false, "secret": false, "description": "Sets the cipherSuites String. This is a 
comma separated String of ciphersuites to configure. If it is not specified, 
then it falls back to getting the ciphersuites from the sslContextParameters 
object." },
-    "clientAuthentication": { "index": 11, "kind": "parameter", "displayName": 
"Client Authentication", "group": "security", "label": "security", "required": 
false, "type": "string", "javaType": "java.lang.String", "deprecated": false, 
"autowired": false, "secret": false, "description": "Sets the configuration 
options for server-side client-authentication requirements. The value must be 
one of NONE, WANT, REQUIRE. If this value is not specified, then it falls back 
to checking the 
sslContextParameters.getServerParameters().getClientAuthentication() value." },
-    "privateKey": { "index": 12, "kind": "parameter", "displayName": "Private 
Key", "group": "security", "label": "security", "required": false, "type": 
"object", "javaType": "java.security.PrivateKey", "deprecated": false, 
"autowired": false, "secret": true, "description": "Set the configured private 
key for use with Raw Public Key." },
-    "pskStore": { "index": 13, "kind": "parameter", "displayName": "Psk 
Store", "group": "security", "label": "security", "required": false, "type": 
"object", "javaType": 
"org.eclipse.californium.scandium.dtls.pskstore.PskStore", "deprecated": false, 
"autowired": false, "secret": false, "description": "Set the PskStore to use 
for pre-shared key." },
-    "publicKey": { "index": 14, "kind": "parameter", "displayName": "Public 
Key", "group": "security", "label": "security", "required": false, "type": 
"object", "javaType": "java.security.PublicKey", "deprecated": false, 
"autowired": false, "secret": false, "description": "Set the configured public 
key for use with Raw Public Key." },
-    "recommendedCipherSuitesOnly": { "index": 15, "kind": "parameter", 
"displayName": "Recommended Cipher Suites Only", "group": "security", "label": 
"security", "required": false, "type": "boolean", "javaType": "boolean", 
"deprecated": false, "autowired": false, "secret": false, "defaultValue": true, 
"description": "The CBC cipher suites are not recommended. If you want to use 
them, you first need to set the recommendedCipherSuitesOnly option to false." },
-    "sslContextParameters": { "index": 16, "kind": "parameter", "displayName": 
"Ssl Context Parameters", "group": "security", "label": "security", "required": 
false, "type": "object", "javaType": 
"org.apache.camel.support.jsse.SSLContextParameters", "deprecated": false, 
"autowired": false, "secret": false, "description": "Set the 
SSLContextParameters object for setting up TLS. This is required for coapstcp, 
and for coaps when we are using certificates for TLS (as opposed to RPK or 
PKS)." },
-    "trustedRpkStore": { "index": 17, "kind": "parameter", "displayName": 
"Trusted Rpk Store", "group": "security", "label": "security", "required": 
false, "type": "object", "javaType": 
"org.eclipse.californium.scandium.dtls.rpkstore.TrustedRpkStore", "deprecated": 
false, "autowired": false, "secret": false, "description": "Set the 
TrustedRpkStore to use to determine trust in raw public keys." }
+    "advancedCertificateVerifier": { "index": 9, "kind": "parameter", 
"displayName": "Advanced Certificate Verifier", "group": "security", "label": 
"security", "required": false, "type": "object", "javaType": 
"org.eclipse.californium.scandium.dtls.x509.NewAdvancedCertificateVerifier", 
"deprecated": false, "autowired": false, "secret": false, "description": "Set 
the AdvancedCertificateVerifier to use to determine trust in raw public keys." 
},

Review Comment:
   Thanks @boaks . The JSON files and `CoAPEndpointConfigurer` are 
automatically generated, in this case from `CoAPEndpoint`.
   
   From what I can see `AdvancedCertificateVerifier` and `PSK` are only used in 
the DTLS configuration setup 
([here](https://github.com/apache/camel/pull/12769/files#diff-fa9b8056c9aaac49ce4368ccadc8e7d9748f3dbdb1d0a59481b8cecdbf8d6cc7R424)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to