JiriOndrusek commented on PR #22612: URL: https://github.com/apache/camel/pull/22612#issuecomment-4252397154
Hi @squakez, I've tried to follow your hints. 1 - I agree with avoiding Op in decorators 2 - I added `span.kind()` into Span and started from it. Unfortunately the `io.opentelemetry.api.trace.Span` needs to know its spanKind before starting. I had to deffer the start of the span into the `makeCurrent` method to be able to detect the spanKind. I put the detection into `OpenTelemetrySpanAdapter` and kept it completely self contained. (I used other tags for it) So I actually did not need the `span.kind()` anymore. What do you think? from my PoV the change is quite small and isolated to opentelemetry2. No API is changed. Test suite is the same as in previous attempts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
