JiriOndrusek opened a new pull request, #22653: URL: https://github.com/apache/camel/pull/22653
fixes https://issues.apache.org/jira/browse/CAMEL-23312 superseeds https://github.com/apache/camel/pull/22612 Adds SpanKind parameter to the Camel telemetry API to enable proper span type classification (CLIENT, SERVER, PRODUCER, CONSUMER, INTERNAL) across different observability backends. ## Changes - **SpanDecorator API**: Added `getSpanKind(String operation)` method to allow decorators to specify appropriate span kinds based on operation type - **SpanLifecycleManager**: Updated `create()` signature to accept spanKind parameter - **Tracer**: Modified to pass spanKind from decorator to lifecycle manager during span creation - **OpenTelemetryTracer**: Implemented spanKind support using OpenTelemetry's `SpanKind` enum - **SpanDecorator implementations**: - `AbstractHttpSpanDecorator`: Returns CLIENT for EVENT_SENT, SERVER for EVENT_RECEIVED - `AbstractMessagingSpanDecorator`: Returns PRODUCER for EVENT_SENT, CONSUMER for EVENT_RECEIVED - `AbstractSpanDecorator`: Returns INTERNAL as default <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
