squakez commented on code in PR #22653:
URL: https://github.com/apache/camel/pull/22653#discussion_r3100819191
##########
components/camel-telemetry/src/main/java/org/apache/camel/telemetry/SpanLifecycleManager.java:
##########
@@ -21,7 +21,7 @@
*/
public interface SpanLifecycleManager {
- Span create(String spanName, Span parent, SpanContextPropagationExtractor
extractor);
+ Span create(String spanName, String spanKind, Span parent,
SpanContextPropagationExtractor extractor);
Review Comment:
Good point, although I doubt anybody is implementing any custom component.
However to be consistent we need to add a minor note as you suggest, but more
important, we need to change the documentation in
https://camel.apache.org/components/next/others/telemetry.html#_implementation_specific_abstraction
to include the new param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
