gnodet commented on code in PR #24405:
URL: https://github.com/apache/camel/pull/24405#discussion_r3520037546
##########
components/camel-ai/camel-weaviate/src/main/java/org/apache/camel/component/weaviate/WeaviateVectorDbConfiguration.java:
##########
@@ -29,29 +29,42 @@ public class WeaviateVectorDbConfiguration implements
Cloneable {
@Metadata(label = "producer",
description = "Scheme used to connect to weaviate")
- @UriParam
- private String scheme;
+ @UriParam(defaultValue = "http")
+ private String scheme = "http";
@Metadata(label = "producer",
description = "Weaviate server host to connect to")
@UriParam
private String host;
+ @Deprecated
@Metadata(label = "producer",
description = "Proxy host to connect to weaviate through")
@UriParam
private String proxyHost;
+ @Deprecated
@Metadata(label = "producer",
description = "Proxy port to connect to weaviate through")
Review Comment:
Minor consistency suggestion: The `scheme` field is initialized with
`private String scheme = "http"` (matching its `@UriParam(defaultValue =
"http")`), but `grpcPort` only declares the default in the annotation without a
field initializer. This means `getGrpcPort()` returns `null` instead of `50051`
until `createClient()` applies the fallback. Consider initializing the field:
```suggestion
private Integer grpcPort = 50051;
```
##########
components/camel-ai/camel-weaviate/pom.xml:
##########
@@ -52,10 +52,12 @@
<version>${langchain4j-version}</version>
</dependency>
+ <!-- classifier=all is required: without it, gRPC's ServiceLoader
breaks in fat JARs -->
<dependency>
<groupId>io.weaviate</groupId>
- <artifactId>client</artifactId>
+ <artifactId>client6</artifactId>
Review Comment:
Question: The `all` classifier produces a shaded/uber JAR that bundles gRPC,
Netty, protobuf, etc. In a large framework like Camel where many components
share these transitive dependencies, is there a risk of classpath conflicts?
The comment explains why it's needed (gRPC ServiceLoader), but it would be good
to confirm no version collisions occur with other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
