orpiske commented on code in PR #24405:
URL: https://github.com/apache/camel/pull/24405#discussion_r3520446929
##########
components/camel-ai/camel-weaviate/src/main/java/org/apache/camel/component/weaviate/WeaviateVectorDbConfiguration.java:
##########
@@ -29,29 +29,42 @@ public class WeaviateVectorDbConfiguration implements
Cloneable {
@Metadata(label = "producer",
description = "Scheme used to connect to weaviate")
- @UriParam
- private String scheme;
+ @UriParam(defaultValue = "http")
+ private String scheme = "http";
@Metadata(label = "producer",
description = "Weaviate server host to connect to")
@UriParam
private String host;
+ @Deprecated
@Metadata(label = "producer",
description = "Proxy host to connect to weaviate through")
@UriParam
private String proxyHost;
+ @Deprecated
@Metadata(label = "producer",
description = "Proxy port to connect to weaviate through")
@UriParam
private Integer proxyPort;
+ @Deprecated
@Metadata(label = "producer",
description = "Proxy scheme to connect to weaviate through")
@UriParam
private String proxyScheme;
+ @Metadata(label = "producer",
+ description = "gRPC host for Weaviate server connection")
+ @UriParam
+ private String grpcHost;
+
+ @Metadata(label = "producer",
+ description = "gRPC port for Weaviate server connection",
defaultValue = "50051")
+ @UriParam(defaultValue = "50051")
Review Comment:
Nit: The field defaults to `null` at the Java level but is documented as
defaulting to `50051` (via `@UriParam`/`@Metadata`). The runtime fallback in
`createClient()` handles this correctly, but initializing the field as `private
Integer grpcPort = 50051;` would be more consistent — similar to how `scheme`
was initialized to `"http"` in this same PR.
```suggestion
private Integer grpcPort = 50051;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
