davsclaus commented on code in PR #1700:
URL: https://github.com/apache/camel-website/pull/1700#discussion_r3628197171
##########
scripts/WebsiteManifestGenerator.java:
##########
@@ -0,0 +1,320 @@
+// VENDORED COPY - do not edit here.
+// Source of truth: apache/camel
+//
dsl/camel-jbang/camel-launcher/src/jreleaser/java/WebsiteManifestGenerator.java
+// To update: re-copy that file over this one, then re-apply this banner. The
body below is
+// kept byte-identical to the upstream source so the sync stays a mechanical
copy.
Review Comment:
This banner says "kept byte-identical to the upstream source," but the file
below has three functional changes vs the current upstream:
1. Added `LICENSE_HEADER` constant (not in upstream)
2. `renderManifest()` prepends `LICENSE_HEADER` (upstream doesn't)
3. `parseStrictManifest()` adds `line.startsWith("#")` skip (upstream only
skips empty lines)
A future sync that follows this banner literally ("re-copy, re-apply
banner") would silently lose these changes.
##########
update-camel-cli-manifest.sh:
##########
@@ -74,58 +56,25 @@ for script in install.sh install.ps1; do
echo " wrote static/$script"
Review Comment:
This loop downloads `install.sh` and `install.ps1` from upstream
`apache/camel main` and overwrites the local copies. Since the upstream
versions do **not** have the comment-skipping logic added in this PR (to
`static/install.sh` and `static/install.ps1`), the next run of this script will:
1. Overwrite the comment-aware install scripts with upstream versions that
reject `#` lines
2. Leave manifests with `##` license headers (written by the Java generator)
3. Break the install flow for users
The upstream `parse_manifest()` has `fail "manifest has unknown key: $key"`
for any line that doesn't match the 4 known keys, and the upstream
`install.ps1` strictly expects exactly 4 lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
