ammachado commented on code in PR #1700:
URL: https://github.com/apache/camel-website/pull/1700#discussion_r3631042411


##########
scripts/WebsiteManifestGenerator.java:
##########
@@ -0,0 +1,320 @@
+// VENDORED COPY - do not edit here.
+// Source of truth: apache/camel
+//   
dsl/camel-jbang/camel-launcher/src/jreleaser/java/WebsiteManifestGenerator.java
+// To update: re-copy that file over this one, then re-apply this banner. The 
body below is
+// kept byte-identical to the upstream source so the sync stays a mechanical 
copy.

Review Comment:
   Addressed upstream by apache/camel#25030, which adds the `LICENSE_HEADER`, 
the `renderManifest()` prepend, and the `parseStrictManifest()` `#`-skip to the 
source file — so once it merges the vendored copy is byte-identical again (bar 
the banner) and a re-copy stops dropping changes. More in the top-level 
comment. _Claude Code on behalf of ammachado_



##########
update-camel-cli-manifest.sh:
##########
@@ -74,58 +56,25 @@ for script in install.sh install.ps1; do
     echo "  wrote static/$script"

Review Comment:
   apache/camel#25030 adds the `#`-comment tolerance to upstream 
`install.sh`/`install.ps1`, so once it merges this step re-fetches 
comment-aware installers and the clobbering goes away. The dependency is 
ordering: #25030 first. _Claude Code on behalf of ammachado_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to