atiaomar1978-hub commented on PR #25034: URL: https://github.com/apache/camel/pull/25034#issuecomment-5050323735
Thanks for the review! I've pushed a follow-up commit addressing all the feedback: - **`batchSize` now actually does something** — rather than dropping the option, I implemented client-side batching. When the message body is a `List` and `batchSize > 0`, the list is split into batches of that size and each batch is sent as a separate insert (`ClickHouseProducer#insertList`). A value of `0` (default) keeps the previous single-call behavior. Added a producer unit test (`insertSplitsListIntoBatchesWhenBatchSizeSet`) asserting a 5-row list with `batchSize=2` produces 3 insert calls (2 + 2 + 1). - **`volatile` client** — the lazily-created `Client` field is now `volatile` for correct double-checked locking in `getClient()`. - **`ssl` option** — the endpoint now forces an `https://` URL when `ssl=true`. - **`username` handling** — simplified; it defaults to `default`. - **`skipITs.ppc64le` / `skipITs.s390x`** — added to the component `pom.xml`, since the ClickHouse server image is not available on those architectures. - **Unrelated change reverted** — restored the `camel-azure-servicebus` section of the 4.22 upgrade guide to its upstream content. Docs and generated catalog metadata were updated accordingly. `mvn install -Psourcecheck` and the unit tests pass locally (integration tests are skipped without Docker). _Claude Opus 4.6 on behalf of @atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
