atiaomar1978-hub commented on PR #25034: URL: https://github.com/apache/camel/pull/25034#issuecomment-5055435844
Thanks @davsclaus for the review — pushed commit `c91dc22149c2` addressing all three points: 1. **Component-level connection settings** — `serverUrl`, `username`, `password`, `ssl` and `compression` can now be configured once on the component (e.g. `camel.component.clickhouse.serverUrl=http://clickhouse:8123`) and are inherited by every endpoint. Endpoint URI options still override component defaults. 2. **Client built in `doStart`** — removed lazy double-checked locking in `getClient()`; the ClickHouse `Client` is now created in `doStart()` when no shared bean is provided, matching the standard Camel component pattern. 3. **`WrappedFile` support** — insert operations now unwrap `WrappedFile` bodies (from camel-file/ftp/sftp) before streaming, consistent with other components like camel-aws2-s3. **Tests:** 19 unit tests pass locally (`mvn verify -pl components/camel-clickhouse`), including two new tests for component-level defaults and WrappedFile inserts. _Claude Opus 4.6 on behalf of @atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
