oscerd commented on PR #25052: URL: https://github.com/apache/camel/pull/25052#issuecomment-5058923528
Thank you both for the reviews. All findings addressed: **Structural fixes:** - ✅ All four result records now `public record` (matching convention across 16+ tool classes) - ✅ Added standard try/catch exception handling pattern - ✅ Added XML route support via `XML_SCHEME_PATTERN` regex — tool now correctly parses `<from uri="scheme:..."/>` syntax **Model-dependent pricing (davsclaus + gnodet):** - ✅ Bedrock display name now reads "AWS Bedrock (model-dependent, estimated as Claude Sonnet 4)" with a pricing note showing the range: Nova Lite ~$0.06/$0.24 vs Opus ~$15/$75 - ✅ LangChain4j Chat pricing note clarified: "free with Ollama/local models" - Agreed that hardcoded pricing is a limitation — the disclaimer already notes costs are approximate. Externalizing pricing data to a config file is a good follow-up. **Test additions:** - ✅ New test for XML route scheme extraction _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
