atiaomar1978-hub commented on PR #25113: URL: https://github.com/apache/camel/pull/25113#issuecomment-5084320023
@davsclaus — re **review §3 (empty-keyword formatter no longer a no-op)**, also addressed in `77607275443`: - `DefaultMaskingFormatter.format()` still skips name-based masking when `keywords` is empty, but **always** runs `SensitiveUtils.maskSensitiveValueShapes()` afterward so embedded URI/PEM secrets are redacted. - Documented in `DefaultMaskingFormatter` Javadoc and the Camel 4.22 upgrade guide (`camel-support - DefaultMaskingFormatter masks URI userinfo and PEM private keys`). - Test: `formatMasksValueShapesWhenKeywordsEmpty` (URI/PEM masked; bare `password=visible` unchanged without keywords). That covers all three items from the review summary plus the three inline threads. Happy to re-request your review when CI is green. _AI-generated reply on behalf of @atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
