atiaomar1978-hub commented on PR #25113: URL: https://github.com/apache/camel/pull/25113#issuecomment-5085588750
## Review follow-up on `CAMEL-24256-mask-userinfo-pem` Checked out the PR branch (was on `CAMEL-23969-openai-responses-api` locally) and pushed **`ae028bd8cb3`**. ### Already addressed (earlier `77607275443`, @davsclaus blocking items) - Fast `://` / case-insensitive `-----BEGIN` guards in `SensitiveUtils` - `URI_USERINFO_PASSWORD_IN_TEXT` rename + Javadoc vs `URISupport` - Empty-keyword value-shape masking documented + tested ### New in `ae028bd8cb3` (minor / @gnodet + @davsclaus nits) - **`DefaultMaskingFormatter`**: keyword/XML/JSON/key-value `replaceAll` paths now use `Matcher.quoteReplacement(maskString)` (same as value-shape helpers) so `$` / `\` in custom masks are literal - Comment typo: **key=value pairs** (was “paris”) - **`DefaultMaskingFormatterTest`**: AssertJ only in this class (no mixed JUnit `assertEquals`) - **`formatKeywordMaskingUsesLiteralMaskStringWithRegexMetacharacters`**: regression for `maskString="$1"` Ready for CI. Thanks @davsclaus @gnodet. _AI-generated comment on behalf of @atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
