gnodet commented on PR #25273: URL: https://github.com/apache/camel/pull/25273#issuecomment-5142679377
_Claude Code on behalf of gnodet_ All review findings have been addressed in commit f267c76: | Finding | Severity | Resolution | |---------|----------|------------| | Destructive `removeAll()` fallback | HIGH | Now throws `IllegalArgumentException` — explicit ID(s) or filter required | | Caller-supplied IDs silently discarded | MEDIUM | Loops with `add(id, embedding)` when no text segments | | FQCN for ArrayList | MEDIUM | Proper import added | | EMBEDDINGS not in CamelLangchain4jAttributes | MEDIUM | Added to `core/camel-api` with `@since 4.22` | | Missing upgrade guide entry | LOW | N/A — the null-body behavior was introduced in this same PR, not a change to existing released behavior | Regarding the **upgrade guide** point: since the REMOVE-with-null-body behavior never existed in a released version (it was introduced in this PR's first commit and corrected in this follow-up), there's no behavioral change for existing users to migrate from — so no upgrade guide entry is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
