atiaomar1978-hub commented on PR #25273: URL: https://github.com/apache/camel/pull/25273#issuecomment-5226902727
## Bugbot review — CAMEL-23953 batch embeddings/embeddingstore Reviewed `investigate-and-fix-camel-23953-camel-langchain4j` vs `main`. ### Scope Adds batch `embedAll` / `addAll` / `removeAll` wiring for LangChain4j embeddings + embedding store; new cross-component `CAMEL_LANGCHAIN4J_EMBEDDINGS` constant; docs + catalog + endpoint DSL regeneration. ### Verified (looks good) - Backward compatible single-item paths preserved (tests confirm). - Prior **HIGH** issue (REMOVE null body → wipe store) **fixed** with explicit `IllegalArgumentException`. - Prior caller-ID batch bug **fixed** (loop `add(id, embedding)` when no text segments). - `CamelLangchain4jAttributes` constant added with `@since 4.22` — consistent with existing pattern. - `RecordingEmbeddingStore` tests verify SDK method dispatch (9 store tests + 3 embed tests). - AssertJ used in new tests; `MockEndpoint`-style patterns not applicable (producer-only). ### Open issues (see inline threads) | Severity | Issue | Status | |----------|-------|--------| | **Medium** | No size validation for `EMBEDDING_IDS` / embeddings / textSegments lists | Open | | **Medium** | Batch embed replaces body with embeddings — text segments not forwarded for store pipeline | Open (doc/UX) | | **Medium** | `body instanceof List` batch trigger is overly broad | Open | | **Low** | Missing **upgrade guide** entry for REMOVE null-body behavior change | Open | | **Low** | Single ADD: `EMBEDDING_ID` silently ignores `TEXT_SEGMENT` | Open (document or validate) | ### Test coverage verdict **Good for merge** — core batch paths and regression guard (`removeWithNoBodyOrFilterThrows`) covered. Add mismatch/edge-case tests before calling it complete. **Bugbot verdict:** Approve with minor follow-ups (upgrade guide + list validation). _AI-generated Bugbot review on behalf of atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
