davsclaus commented on PR #25203: URL: https://github.com/apache/camel/pull/25203#issuecomment-5187939603
_Claude Code on behalf of davsclaus_ To clarify finding #1 from the review: the three new classes in `dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/mcp/` (`JbangDevMcpMainListener`, `JbangDevMcpServer`, `ToolMcpSchemas`) are Camel runtime services — they extend `ServiceSupport`, hook into the CamelContext lifecycle, and wire up Vert.x routers. That kind of code does not belong in `camel-jbang-core`, which is for CLI commands and tooling. These classes should be moved to `camel-kamelet-main` (or into `camel-mcp-server` itself) where other runtime services live, and loaded dynamically when the JAR is downloaded on demand. The `mainListenerClasses` property is already string-based, so `KameletMain` just needs the FQCN — no compile-time dependency required in `camel-jbang-core`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
