atiaomar1978-hub commented on PR #25203: URL: https://github.com/apache/camel/pull/25203#issuecomment-5188441652
## Review feedback addressed (`7f461878c39`) _AI-generated summary on behalf of atiaomar1978-hub_ Replied inline to @davsclaus's three review comments. Summary: | Review item | Fix | |-------------|-----| | **Compile dependency on `camel-mcp-server`** | Removed from `camel-jbang-core`. Dev MCP classes moved to `camel-mcp-server` (`org.apache.camel.component.mcp.server.jbang.*`), loaded when `Run.java` downloads `camel:mcp-server` on `--mcp`. `ToolRegistry` accessed reflectively to avoid Maven reactor cycle. | | **Upgrade guide `--mcp` section** | Removed from `camel-4x-upgrade-guide-4_22.adoc` (migration-only doc). | | **FQCN in `ToolMcpSchemasTest`** | Test removed; schema coverage in `JbangDevMcpServerTest` with proper imports. | ### Tests ``` mvn install -pl components/camel-ai/camel-mcp-server -DskipTests mvn test -pl dsl/camel-jbang/camel-jbang-core -Dtest=RunMcpOptionTest,JbangDevMcpServerTest ``` 4 tests passing. **Note:** CAMEL-24308 namespace alignment (`camel.mcp.*` vs `camel.server.mcp-*`) remains pending committer design decision as previously agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
