davsclaus commented on code in PR #25361:
URL: https://github.com/apache/camel/pull/25361#discussion_r3728582389


##########
core/camel-core-model/src/main/java/org/apache/camel/model/RecipientListDefinition.java:
##########
@@ -109,6 +109,13 @@ public class RecipientListDefinition<Type extends 
ProcessorDefinition<Type>> ext
     @Metadata(label = "advanced", javaType = "java.lang.Boolean",
               description = "Shares the UnitOfWork with the parent and each of 
the sub messages. Recipient List will by default not share unit of work between 
the parent exchange and each recipient exchange. This means each sub exchange 
has its own individual unit of work.")
     private String shareUnitOfWork;
+    @XmlAttribute
+    @Metadata(label = "advanced,security",
+              description = "Sets an optional comma-separated allow-list of 
component schemes that the dynamic recipient"
+                            + " may resolve to (e.g. http,https). When set, a 
dynamic endpoint whose scheme is not in the"
+                            + " list is rejected. This is a defence-in-depth 
restriction, useful for low-code / Kamelet"
+                            + " deployments; by default (unset) any scheme is 
allowed.")
+    private String allowedSchemes;

Review Comment:
   Fixed — added `this.allowedSchemes = source.allowedSchemes;` to the copy 
constructor. Good catch.



##########
core/camel-core-model/src/main/java/org/apache/camel/model/RoutingSlipDefinition.java:
##########
@@ -54,6 +54,13 @@ public class RoutingSlipDefinition<Type extends 
ProcessorDefinition<Type>> exten
               description = "Configures the cache size for ProducerCache which 
caches producers for reuse. The default cache size is 1000."
                             + " Set to -1 to turn off caching.")
     private String cacheSize;
+    @XmlAttribute
+    @Metadata(label = "advanced,security",
+              description = "Sets an optional comma-separated allow-list of 
component schemes that the dynamic recipient"
+                            + " may resolve to (e.g. http,https). When set, a 
dynamic endpoint whose scheme is not in the"
+                            + " list is rejected. This is a defence-in-depth 
restriction, useful for low-code / Kamelet"
+                            + " deployments; by default (unset) any scheme is 
allowed.")
+    private String allowedSchemes;

Review Comment:
   Fixed — same addition in RoutingSlipDefinition's copy constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to