davsclaus commented on PR #25361:
URL: https://github.com/apache/camel/pull/25361#issuecomment-5204377724
Thanks for the thorough review @davsclaus — all points addressed:
**Copy constructors** — both `RecipientListDefinition` and
`RoutingSlipDefinition` now copy `allowedSchemes`. (The other three were
already correct.)
**Positive test** — added `recipientListAllowsMatchingScheme()` that sends
to `mock:result` with `allowedSchemes("mock")` and asserts the message arrives.
**`ignoreInvalidEndpoints` interaction** — agreed that `allowedSchemes`
should always be a hard security boundary. Moved the `checkAllowedSchemes` call
*before* the `ignoreInvalidEndpoints` catch in both `RecipientListProcessor`
and `PollEnricher`. A disallowed scheme now always fails, consistent with
`toD`. `RoutingSlip`/`DynamicRouter` already hard-failed (their catch sets the
exchange exception and breaks, without checking `ignoreInvalidEndpoints`).
_Claude Code on behalf of Andrea Cosentino (@oscerd)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
