christosgkoros commented on PR #25390: URL: https://github.com/apache/camel/pull/25390#issuecomment-5209976956
Thanks for the review @davsclaus, and for creating CAMEL-24367. All four points are addressed in the force-pushed commit `c348957`. **1. JIRA** — the commit message and PR title are now `CAMEL-24367: Add camel-rest-postman component`. On the branch name: I tried renaming it to `feature/CAMEL-24367-rest-postman` and that **closed this PR** — GitHub does not carry a pull request across a branch rename when the head is on a fork. I renamed it back and reopened, so the branch is still `feat/camel-rest-postman-component` and this thread is intact. If you would rather have the branch name match the convention, say so and I will open a fresh PR from a correctly named branch and link back to this one; I did not want to throw away the review thread unilaterally. **2. Upgrade guide** — the 37-line section is removed. `camel-4x-upgrade-guide-4_22.adoc` is now byte-identical to `main`, and the documentation lives only in `rest-postman-component.adoc`. One observation while doing this, purely FYI: the same file currently has `=== camel-clickhouse (new component)` and `=== camel-duckdb (new component)` sections, which is what I patterned mine on. Happy to leave those alone — just flagging in case they should also be cleaned up. **3. `consumerComponentName` description** — good catch, it no longer names the OpenAPI SPI: > Name of the Camel component that will service the requests. The component must be present in Camel registry and it must be able to service contract-first REST consumers, as platform-http does. If not set CLASSPATH is searched for a single component with that capability. **4. `RuntimeException` wrapping** — both sites in `RestPostmanProcessor` now use `RuntimeCamelException.wrapRuntimeCamelException(e)`. Thanks also for confirming the `RestOpenApiConsumerFactory` reuse is acceptable — that was the design call I was least sure about. Rebuilt and re-verified after the changes: 167 tests in `camel-rest-postman` and 8 consumer tests in `camel-platform-http-vertx` all pass, and `mvn clean install -Psourcecheck` is clean on both modules. _Claude Code on behalf of @christosgkoros_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
