christosgkoros commented on PR #25390:
URL: https://github.com/apache/camel/pull/25390#issuecomment-5224812596
@davsclaus thanks — all three addressed in `70a80ea`.
**1. Variable resolver expanding Camel property functions (Medium)** — good
catch, and I took option (b) rather than only documenting it, since
documentation would not stop it.
`PostmanVariableResolver` now refuses to hand any name containing `:` to
`resolvePropertyPlaceholders`. Camel's placeholder functions are uniformly
`prefix:argument`, so this blocks `env:`, `sys:`, `bean:` and the vault
functions in one rule, while plain names still resolve — an operator can still
override any collection variable through properties, which was the point of the
fallback.
Three tests were added: that `+{{env:PATH}}+`, `+{{sys:user.home}}+` and
`+{{bean:foo}}+` are left literal, that a plain name still resolves from
properties, and that the collection scope still wins over properties. The
behaviour is documented in the Variables section of the component page.
**2. Per-call `HttpClient` (Low)** — fixed; it is now built once in the
constructor. Redirect rejection and the SSL context moved onto the shared
client, so the security behaviour is unchanged.
**3. Sub-exchange lifecycle** — not intentional so much as unexamined, so
thank you for asking. Nothing in the `endpoint.createExchange()` →
`producer.process()` path starts a unit of work, so `getUnitOfWork()` is null
today and there is nothing to release. Rather than rely on that invariant
continuing to hold, the runner now releases one when present via
`UnitOfWorkHelper.doneUow`, following the pattern in `ResilienceProcessor`.
Verified after the change: 170 tests in `camel-rest-postman` (up from 167),
8 consumer tests in `camel-platform-http-vertx`, `-Psourcecheck` clean, and a
full build followed by the codegen chain leaves the tree clean.
_Claude Code on behalf of @christosgkoros_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
