atiaomar1978-hub commented on PR #24844: URL: https://github.com/apache/camel/pull/24844#issuecomment-5226867520
## Bugbot review Reviewed `camel-apicurio-registry-component` vs `main` (~3k LOC new component + test-infra). ### Scope New **Preview** component wrapping Apicurio Registry v3 REST API via `apicurio-registry-java-sdk` 3.3.0. Producer ops (CRUD, search, validate/compatibility dry-run), consumer polls new versions by `globalId` watermark, basic/OIDC auth, unit tests (mocked SDK), ITs (Testcontainers `quay.io/apicurio/apicurio-registry:3.3.0`), AsciiDoc docs. ### Verified (looks good) - Clean Camel layout: `Component` / `Endpoint` / `Producer` / `Consumer` / `Configuration` / `Constants`. - `HeaderSelectorProducer` + `@InvokeOnHeader` for operation dispatch. - Secrets marked `security = "secret"` on username/password/clientSecret. - Test-infra follows Camel conventions (`@InfraService`, `container.properties`, quay.io image). - Good operation coverage in mocked producer tests + IT suite for create/search/validate/consumer. ### Issues flagged (inline comments posted) | Severity | Area | Finding | |----------|------|---------| | **Major** | `cacheTtl` option | Documented URI param never used in code | | **Major** | Consumer watermark | In-memory `lastSeenGlobalId` — restart replays all versions | | **Major** | Consumer ordering | Unsorted version list can skip IDs if API order ≠ globalId order | | **Major** | Producer body | `getBody(String.class)` unsuitable for binary AVRO/Protobuf payloads | | **Medium** | `getArtifactContent` | Returns raw `InputStream` — leak risk without documented lifecycle | | **Medium** | `testCompatibility` | Broad `catch (Exception)` masks network/auth errors | | **Medium** | Dependency mgmt | SDK version local to module pom, not parent BOM | | **Minor** | Docs vs reality | PR text says container `3.0.6`, properties use `3.3.0` | **Bugbot verdict:** Solid first component drop — approve with follow-ups above before Preview promotion. No security blockers (producer is trusted route config; consumer polls configured registry). _AI-generated Bugbot review on behalf of atiaomar1978-hub._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
